Use _REMOTE_USER when available - #264
Merged
Samruddhi Khandale (samruddhikhandale) merged 7 commits intoNov 28, 2022
Merged
Conversation
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
This is awesome. Thank you for the PR. ✨
Added a comment which should help fix the Python tests.
The failing oryx tests (jammy) are expected.
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
Member
Author
|
Samruddhi Khandale (@samruddhikhandale) joshspicer Adapted to feedback. |
Member
|
Oops, I forgot this existed and created a duplicate #309 🤦♀️ |
Samruddhi Khandale (samruddhikhandale)
approved these changes
Nov 28, 2022
Samruddhi Khandale (samruddhikhandale)
deleted the
clantz/use-remote-user-env
branch
November 28, 2022 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates features to take advantage of the new _REMOTE_USER environment variable. It leaves the existing logic in place to handle older versions of the dev container CLI (and to try to be smart in the case when no remote user is set).
Priority is:
USERNAME(if this was added as an option)_REMOTE_USERautomatic- this is the final fallback to try to auto-detect and for back compat.The PR also makes sure we are quoting inbound feature options to avoid spaces, newlines, etc causing problems.